Merged
Conversation
zstone1
reviewed
Jun 23, 2024
Contributor
zstone1
left a comment
There was a problem hiding this comment.
A couple small comments. Going via "charge_variation is uniformly continuous" is clever indeed. That's a nice trick to stay general for as long as possible.
f31bac9 to
4495fbd
Compare
Member
Author
|
@t6s we renamed |
62ad570 to
26ea7ef
Compare
26ea7ef to
26ad99c
Compare
Member
Author
|
Got an offline approval by Zachary for this PR, will merge soon. |
1 task
Co-authored-by: Zachary Stone <zstonex@gmail.com>
26ad99c to
880d192
Compare
880d192 to
39d9d05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See issue #965
Provides also the Borel-Cantelli lemma (and the limit superior of the sequence of sets) and continuity of the indefinite integral at the borders (which is maybe the part that is not the cleanest).
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers